[feat] Don't hardcode database block IDs

config.ts

@@ -1,3 +1 @@
 export const NOTION_KEY = process.env.NOTION_KEY;
-export const LAWS_BLOCK_ID =
-  process.env.LAWS_BLOCK_ID ?? "d02fa51eda254c9fa4b97e5f9beb1a86";

lib/notion.ts

@@ -3,3 +3,23 @@ import { NOTION_KEY } from "../config";
 const { Client } = require("@notionhq/client");
 
 export const notion = new Client({ auth: NOTION_KEY });
+
+export type DatabaseType = "laws" | "advice";
+
+/**
+ * Translates incoming GET parameters into a valid block ID.
+ * @param type
+ * @returns string
+ */
+export function getDatabaseId(type: DatabaseType): string | undefined {
+  switch (type) {
+    case "laws":
+      return "d02fa51eda254c9fa4b97e5f9beb1a86";
+
+    case "advice":
+      return "9515c0f02e454e968c44336bd1beb463";
+
+    default:
+      return undefined;
+  }
+}

pages/api/getTopicList.ts

@@ -1,13 +1,16 @@
 // Next.js API route support: https://nextjs.org/docs/api-routes/introduction
 import type { NextApiRequest, NextApiResponse } from "next";
-import { LAWS_BLOCK_ID } from "../../config";
-import { notion } from "../../lib/notion";
+import { DatabaseType, getDatabaseId, notion } from "../../lib/notion";
 
 interface Topic {
   blockId: string;
   name: string;
 }
 
+interface Error {
+  status: string;
+}
+
 function getTopicsInDatabase(notionResp: any): Topic[] {
   return notionResp.results.map((block: any) => ({
     blockId: block.id,
@@ -17,16 +20,24 @@ function getTopicsInDatabase(notionResp: any): Topic[] {
 
 export default async function handler(
   req: NextApiRequest,
-  res: NextApiResponse<Topic[]>
+  res: NextApiResponse<Topic[] | Error>
 ) {
-  const resp = await notion.databases.query({
-    database_id: LAWS_BLOCK_ID,
-    sorts: [
-      {
-        property: "Created",
-        direction: "ascending",
-      },
-    ],
-  });
-  res.status(200).json(getTopicsInDatabase(resp));
+  const {
+    query: { type },
+  } = req;
+  const blockId = getDatabaseId(type as DatabaseType);
+  if (!blockId) {
+    res.status(404).json({ status: "Not found." });
+  } else {
+    const resp = await notion.databases.query({
+      database_id: blockId,
+      sorts: [
+        {
+          property: "Created",
+          direction: "ascending",
+        },
+      ],
+    });
+    res.status(200).json(getTopicsInDatabase(resp));
+  }
 }